On Fri, 18 Jan 2008, Peter Jeremy wrote: > On Fri, Jan 18, 2008 at 08:17:40AM +1030, Daniel O'Connor wrote: > >On Fri, 18 Jan 2008, John Baldwin wrote: > >> amd64 uses link_elf_obj.c, all the other archs use link_elf.c, > >> hence the duplication. > > Then why does amd64 need link_elf.c at all?
I wonder if it's because you can't put !amd64 in sys/conf/files :) (so you'd have to put it in every platform specific files instead) > >I guess one option would be to put #ifdef amd64 around the error > > message in link_elf.c. > > If there's a possibility that multiple ELF linkers could be required > in the future, a cleaner option might be to make link_elf_error() > just cache the error message and only report it after all possible > linkers have refused to load the file. That would be the Right Way(tm).. probably just #ifndef amd64'ing link_elf.c will be easier :) One thing that gets me is why I get this problem but noone else seems to.. -- Daniel O'Connor software and network engineer for Genesis Software - http://www.gsoft.com.au "The nice thing about standards is that there are so many of them to choose from." -- Andrew Tanenbaum GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C
signature.asc
Description: This is a digitally signed message part.