Re: svn commit: r341825 - in head: . contrib/compiler-rt contrib/compiler-rt/include/sanitizer contrib/compiler-rt/include/xray contrib/compiler-rt/lib/BlocksRuntime contrib/compiler-rt/lib/asan contri...

[Dimitry Andric]

On 18 Feb 2019, at 12:40, Charlie Li via freebsd-toolchain 
<freebsd-toolchain@freebsd.org> wrote:
> 
> On 11/12/2018 14:05, Dimitry Andric wrote:
>>  head/contrib/libc++/include/type_traits
>> 
> The change to the above named file breaks building any C++ code
> containing _Float16 with devel/llvm80-8.0.0.r2 (and probably later, but
> not 8.0.0.r1 or any earlier LLVM) on head (but not
> projects/clang800-import, obviously). Example error, from our own copy
> of LLVM libunwind:
> 
> --- libunwind.o ---
> In file included from
> /usr/src/contrib/llvm/projects/libunwind/src/libunwind.cpp:18:
> In file included from
> /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/new:91:
> In file included from
> /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/exception:83:
> /usr/obj/usr/src/amd64.amd64/tmp/usr/include/c++/v1/type_traits:740:56:
> error: _Float16 is not supported on this target
> template <>          struct __libcpp_is_floating_point<_Float16>    :
> public true_type {};
>                                                       ^
> 1 error generated.
> *** [libunwind.o] Error code 1

Hm, which target did you compile for?  I have run multiple universe
builds, so I thought I had covered all possible targets.  Or are you
building with gcc?


> Upstream LLVM has already reverted this: https://reviews.llvm.org/D53670
> 
> world builds successfully after applying the upstream revert. Ports that
> use the clang portion of devel/llvm80 when set in DEFAULT_VERSIONS, ie
> gecko@, also build successfully.

Thanks, I'll take a look.

-Dimitry

signature.asc
Description: Message signed with OpenPGP