Re: [patch] fix uplcom(4) clear stall logic for PL2303HX

[Mark Johnston]

On Wed, Nov 21, 2012 at 11:07:20PM +0100, Hans Petter Selasky wrote:
> Here you go:
> 
> http://svnweb.freebsd.org/changeset/base/243380
> 
> Please test and verify.
> 
> --HPS

Yep, it's working. Thanks a lot!

When I was debugging the problem I noticed the UQ_OPEN_CLEARSTALL quirk,
and then later discovered that it no longer has any effect. Is there any
reason for keeping it around? Or can it be removed (patch below)?

Thanks,
-Mark

diff --git a/share/man/man4/usb_quirk.4 b/share/man/man4/usb_quirk.4
index 65deafa..f017e01 100644
--- a/share/man/man4/usb_quirk.4
+++ b/share/man/man4/usb_quirk.4
@@ -76,8 +76,6 @@ mouse sends an unknown leading byte
 mouse has Z-axis reversed
 .It UQ_NO_STRINGS
 string descriptors are broken
-.It UQ_OPEN_CLEARSTALL
-device needs clear endpoint stall
 .It UQ_POWER_CLAIM
 hub lies about power status
 .It UQ_SPUR_BUT_UP
diff --git a/sys/dev/usb/quirk/usb_quirk.c b/sys/dev/usb/quirk/usb_quirk.c
index fe15a0a..8f35584 100644
--- a/sys/dev/usb/quirk/usb_quirk.c
+++ b/sys/dev/usb/quirk/usb_quirk.c
@@ -508,7 +508,6 @@ static const char *usb_quirk_str[USB_QUIRK_MAX] = {
        [UQ_MS_LEADING_BYTE]    = "UQ_MS_LEADING_BYTE",
        [UQ_MS_REVZ]            = "UQ_MS_REVZ",
        [UQ_NO_STRINGS]         = "UQ_NO_STRINGS",
-       [UQ_OPEN_CLEARSTALL]    = "UQ_OPEN_CLEARSTALL",
        [UQ_POWER_CLAIM]        = "UQ_POWER_CLAIM",
        [UQ_SPUR_BUT_UP]        = "UQ_SPUR_BUT_UP",
        [UQ_SWAP_UNICODE]       = "UQ_SWAP_UNICODE",
diff --git a/sys/dev/usb/quirk/usb_quirk.h b/sys/dev/usb/quirk/usb_quirk.h
index 32a60a1..15d5f15 100644
--- a/sys/dev/usb/quirk/usb_quirk.h
+++ b/sys/dev/usb/quirk/usb_quirk.h
@@ -54,7 +54,6 @@ enum {
        UQ_MS_LEADING_BYTE,     /* mouse sends an unknown leading byte */
        UQ_MS_REVZ,             /* mouse has Z-axis reversed */
        UQ_NO_STRINGS,          /* string descriptors are broken */
-       UQ_OPEN_CLEARSTALL,     /* device needs clear endpoint stall */
        UQ_POWER_CLAIM,         /* hub lies about power status */
        UQ_SPUR_BUT_UP,         /* spurious mouse button up events */
        UQ_SWAP_UNICODE,        /* has some Unicode strings swapped */
_______________________________________________
freebsd-usb@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-usb
To unsubscribe, send any mail to "freebsd-usb-unsubscr...@freebsd.org"