On Wed, Feb 15, 2017 at 02:06:36PM +0200, liuyingdong wrote: > On 2017/2/13 12:05, liuyingdong wrote: > > 发件人: roger....@citrix.com [mailto:roger....@citrix.com] > > 发送时间: 2017年2月10日 17:12 > > 收件人: Liuyingdong <liuyingd...@huawei.com> > > 抄送: freebsd-xen@freebsd.org; Suoben <suo...@huawei.com>; Zhaojun (Euler) > > <zhao.zhao...@huawei.com>; Wanglinkai <wanglin...@huawei.com>; chuzhaosong > > <chuzhaos...@huawei.com>; Wangchunfeng (Ivan) <chunfeng.w...@huawei.com>; > > Gaoxiaodong (Leo) <leo.gaoxiaod...@huawei.com> > > 主题: Multiple patch review (was: Re: 答复: 答复: [PATCH]netfront: need release > > all resources) after adding and removing NICs time and again > > > > On Tue, Feb 07, 2017 at 04:55:34PM +0000, Liuyingdong wrote: > >> Hi Roger, > >> I am so sorry and please review tne below URL: > >> https://lists.freebsd.org/pipermail/freebsd-xen/2017-February/002957.h > >> tml > > > > Hello, > > > > Thanks for the patches, and sorry for the delay. It seems like you have not > > applied some of my comments, so I will have to re-post them here. If some > > of the comments don't apply for whatever reason, please reply back and > > explain why, or else this is not going to progress in an useful way for any > > of us. > > > > I would also request you to look into using `git send-email`, reviewing > > your patches as attachments is not very comfortable. Or else, you could > > create an account to https://reviews.freebsd.org/ and upload the patches > > there assigning me as a reviewer. > > > I have created an account to https://reviews.freebsd.org/ and uploaded the > patches but I cann't assign you as a reviewer so I assign visible to All > Users. > The three modified patches are as follows: > 1.https://reviews.freebsd.org/differential/diff/25207/ > 2.https://reviews.freebsd.org/differential/diff/25208/ > 3.https://reviews.freebsd.org/differential/diff/25209/
You need to finish creating the revision, click on "Continue", and add a title/description and reviewers, see https://wiki.freebsd.org/Phabricator#Create_a_Revision_via_Web_Interface for more information. Roger. _______________________________________________ freebsd-xen@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xen To unsubscribe, send any mail to "freebsd-xen-unsubscr...@freebsd.org"
