<URL: http://bugs.freeciv.org/Ticket/Display.html?id=39858 >

> [wsimpson - Wed Nov 14 11:28:11 2007]:

> In GTK2 for 2.1 -- just tested (again) -- the unknown tile does *not*
> popup
> the info box.  That's the correct solution!  It's a client problem....

This patch fixes text.c to give a better info text.  Not popping up the
window at all is also a solution but I see no problem with showing some
descriptive unknown-tile text either.

-jason

Index: client/text.c
===================================================================
--- client/text.c	(revision 13944)
+++ client/text.c	(working copy)
@@ -29,6 +29,7 @@
 #include "map.h"
 #include "unitlist.h"
 
+#include "climap.h"
 #include "climisc.h"
 #include "civclient.h"
 
@@ -94,6 +95,13 @@
   static struct astring str = ASTRING_INIT;
 
   astr_clear(&str);
+  if (client_tile_get_known(ptile) == TILE_UNKNOWN) {
+    /* Sanity check for clicking on unknown tiles. */
+    astr_add(&str, _("Unknown tile:\n"
+		     "you must explore this tile to\n"
+		     "gain information about it."));
+    return str.str;
+  }
 #ifdef DEBUG
   astr_add_line(&str, _("Location: (%d, %d) [%d]"), 
 		ptile->x, ptile->y, ptile->continent); 
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to