<URL: http://bugs.freeciv.org/Ticket/Display.html?id=40060 >

This doesn't reliably crash for me either.  But the memory error is
obvious enough from the backtrace and shows up in valgrind.  This will
cause arbitrary memory reads every time /debug is done with no parameters.

Looks like this affects only 2.2/trunk.  This patch should fix it.

-jason

Index: server/stdinhand.c
===================================================================
--- server/stdinhand.c	(revision 14356)
+++ server/stdinhand.c	(working copy)
@@ -2390,7 +2390,7 @@
     } unit_list_iterate_end;
   } else if (ntokens > 0 && strcmp(arg[0], "timing") == 0) {
     TIMING_RESULTS();
-  } else if (strcmp(arg[0], "ferries") == 0) {
+  } else if (ntokens > 0 && strcmp(arg[0], "ferries") == 0) {
     if (game.debug[DEBUG_FERRIES]) {
       game.debug[DEBUG_FERRIES] = FALSE;
       cmd_reply(CMD_DEBUG, caller, C_OK, _("Ferry system is no longer "
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to