Follow-up Comment #3, patch #1280 (project freeciv):
Reading this patch, I'm not totally convinced by some ways:
* Only notify_player() and notify_embassies() have en entry for offline
events. Shouldn't at least notify_team() and notify_research() have it too?
And what about notify_conn()?
* Why do you overwrite the event type and the tile in notify_embassies() with
E_TREATY_EMBASSY and NULL?
* I don't think that offline chat and offline events should be split in
different features. They do exactly the same. And I don't see any
application of using only 1/2.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?1280>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
