Update of patch #1910 (project freeciv): Status: None => In Progress Assigned to: None => pepeto Planned Release: => 2.3.0
_______________________________________________________ Follow-up Comment #1: As I used to play regularly online, I know this is a useful feature. However, the patch is not really good yet, I am thinking about something more like warclient. What is wrong: * When connection is lost, behaviour is not granted. * If you pass an invalid username to the command, it will print the list of the connections you are ignoring, instead of print warning. * You cannot modify *_gen.[ch] files because they are auto-generated. * Indentation is not correct in regard to CodingStyle documentation. * Using // C++ style comment is not allowed (see CodingStyle documentation). Anyway, your username is not useful for the code. :) What can be improved: * Ignore list could use the connection patten like in warclient. Most tools already exist in trunk/ to allow this. _______________________________________________________ Reply to this item at: <http://gna.org/patch/?1910> _______________________________________________ Message posté via/par Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev