Follow-up Comment #4, patch #2019 (project freeciv):

You are sharing static datas in the files that are not needed. A good design
would be to only use one only reference (probably in mapimg_dialog_popup())
to a GtkWidget. mapimg_dialog_new() should return the created GtkWidget, not
sharing static datas.

Also, all *_mapimg_dialog() functions doesn't match Freeciv coding style,
they should be named mapimg_dialog_*().


    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?2019>

_______________________________________________
  Message posté via/par Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to