Follow-up Comment #2, bug #17647 (project freeciv):
Attached patch is an improvement against current situation, but assert it
adds shows that there is more similar adv_data_get() calls after
adv_data_phase_done().
- Call I earlier sent backtrace about, has been fixed
- Asserts added to detect other illegal adv_data_get() calls
- There were problems in data phase handling when barbarian player was
created. Fixed.
Another, harder to fix, backtrace:
#2 0x000000000042b61e in adv_data_get (pplayer=0x10e0b70)
at ../../../server/advisors/advdata.c:723
#3 0x00000000004ae5c0 in aiferry_clear_boat (punit=0xbc4e90) at
../../ai/aiferry.c:183
#4 0x000000000049ccf9 in ai_unit_close (punit=0xbc4e90) at
../../ai/aiunit.c:2716
#5 0x000000000058adc8 in destroy_unit_virtual (punit=0xbc4e90) at
../../common/unit.c:1671
#6 0x000000000041e947 in server_remove_unit (punit=0xbc4e90) at
../../server/unittools.c:1520
#7 0x00000000004236c8 in wipe_unit (punit=0xbc4e90) at
../../server/unittools.c:1608
#8 0x00000000004087a7 in remove_illegal_armistice_units (plr1=<value
optimized out>,
plr2=0x111da80) at ../../server/srv_main.c:663
#9 0x0000000000408b2d in update_diplomatics () at
../../server/srv_main.c:700
#10 end_turn () at ../../server/srv_main.c:1122
#11 0x000000000040d144 in srv_running () at ../../server/srv_main.c:2218
#12 srv_main () at ../../server/srv_main.c:2609
#13 0x0000000000404545 in main (argc=<value optimized out>,
argv=0x7fffffffe258)
at ../../server/civserver.c:389
(file #12281, file #12282)
_______________________________________________________
Additional Item Attachment:
File name: PhaseInitDoneFix_17647.diff Size:7 KB
File name: PhaseInitDoneFix-S2_3_17647.diff Size:6 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?17647>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
