URL:
  <http://gna.org/bugs/?17678>

                 Summary: Warnings about wonders (etc) when loading S2_3
experimental savegame in trunk
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Wed Feb  9 01:40:45 2011
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: trunk r19268
         Discussion Lock: Any
        Operating System: None
         Planned Release: 2.4.0

    _______________________________________________________

Details:

After fixing bug #17677, when I load the attached savegame, created with the
experimental ruleset on S2_3, into trunk r19268, I get loads of warnings:

2: [T000 - 2011/02/09 01:13:27] in sg_load_compat() [savegame2.c::5612]: Run
compatibility function for version: <10 (save file: 3; server: 10).
[...]
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: assertion
'adv->phase_is_initialized' failed.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: Please
report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (8 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (7 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (7 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (8 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (9 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (11 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (8 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (10 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (13 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (12 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (11 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (14 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (12 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for Copernicus'
Observatory (nb 44), it points to city nb 343.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for Copernicus'
Observatory (nb 44), the player Vercingétorix (nb 0) doesn't have this
wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
28,   71) in "Lille"[12]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (11 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
last message repeated 2 times
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (10 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for Magellan's
Expedition (nb 57), it points to city nb 184.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for Magellan's Expedition
(nb 57), the player Vercingétorix (nb 0) doesn't have this wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
51,   45) in "Nice"[10]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (10 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for Colossus (nb 43), it
points to city nb 155.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for Colossus (nb 43), the
player Vercingétorix (nb 0) doesn't have this wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
57,   37) in "Bordeaux"[10]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (7 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (8 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for Palace (nb 23), it
points to city nb 131.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_small_wonder(pplayer, pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
55,   39) in "Paris"[8]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for A.Smith's Trading
Co. (nb 42), it points to city nb 131.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for A.Smith's Trading Co.
(nb 42), the player Vercingétorix (nb 0) doesn't have this wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
55,   39) in "Paris"[8]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for Darwin's Voyage (nb
46), it points to city nb 131.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for Darwin's Voyage (nb
46), the player Vercingétorix (nb 0) doesn't have this wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
55,   39) in "Paris"[8]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for King Richard's
Crusade (nb 54), it points to city nb 131.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for King Richard's Crusade
(nb 54), the player Vercingétorix (nb 0) doesn't have this wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
55,   39) in "Paris"[8]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for Leonardo's Workshop
(nb 55), it points to city nb 131.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for Leonardo's Workshop
(nb 55), the player Vercingétorix (nb 0) doesn't have this wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
55,   39) in "Paris"[8]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for Michelangelo's
Chapel (nb 60), it points to city nb 131.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for Michelangelo's Chapel
(nb 60), the player Vercingétorix (nb 0) doesn't have this wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
55,   39) in "Paris"[8]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for Pyramids (nb 62), it
points to city nb 131.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for Pyramids (nb 62), the
player Vercingétorix (nb 0) doesn't have this wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
55,   39) in "Paris"[8]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Vercingétorix (nb 0) has outdated wonder info for United Nations (nb
67), it points to city nb 131.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for United Nations (nb
67), the player Vercingétorix (nb 0) doesn't have this wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
55,   39) in "Paris"[8]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
2: [T219 - 2011/02/09 01:13:28] in sg_load_players() [savegame2.c::3003]:
Vercingétorix has been added as human player.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: assertion
'adv->phase_is_initialized' failed.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: Please
report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (5 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (5 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (5 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Paul Eyschen (nb 1) has outdated wonder info for Great Library (nb 48),
it points to city nb 291.
1: [T219 - 2011/02/09 01:13:28] in city_from_great_wonder()
[improvement.c::633]: Game has outdated wonder info for Great Library (nb 48),
the player Paul Eyschen (nb 1) doesn't have this wonder.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_great_wonder(pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
39,   51) in "Péiteng"[3]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (5 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (5 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (5 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (5 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Paul Eyschen (nb 1) has outdated wonder info for Palace (nb 23), it
points to city nb 132.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_small_wonder(pplayer, pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
38,   56) in "Lëtzebuerg"[4]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
2: [T219 - 2011/02/09 01:13:28] in sg_load_players() [savegame2.c::3000]:
Paul Eyschen has been added as Hard level AI-controlled player.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: assertion
'adv->phase_is_initialized' failed.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: Please
report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (6 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (6 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Nicolau Lobato (nb 2) has outdated wonder info for Palace (nb 23), it
points to city nb 134.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_small_wonder(pplayer, pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
61,   17) in "Lospalos"[4]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
2: [T219 - 2011/02/09 01:13:28] in sg_load_players() [savegame2.c::3000]:
Nicolau Lobato has been added as Hard level AI-controlled player.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: assertion
'adv->phase_is_initialized' failed.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: Please
report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (1 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (6 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (5 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
last message repeated 2 times
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
last message repeated 1 time (total 3 repeats)
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Karl Friedrich (nb 3) has outdated wonder info for Palace (nb 23), it
points to city nb 133.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_small_wonder(pplayer, pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
33,   40) in "Karlsruhe"[3]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
2: [T219 - 2011/02/09 01:13:28] in sg_load_players() [savegame2.c::3000]:
Karl Friedrich has been added as Hard level AI-controlled player.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: assertion
'adv->phase_is_initialized' failed.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: Please
report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
last message repeated 2 times
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
last message repeated 1 time (total 3 repeats)
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (7 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
last message repeated 2 times
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
last message repeated 1 time (total 3 repeats)
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Askia Mohammad Benkan (nb 4) has outdated wonder info for Palace (nb
23), it points to city nb 247.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_small_wonder(pplayer, pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
48,   19) in "Agadez"[4]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (6 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
2: [T219 - 2011/02/09 01:13:28] in sg_load_players() [savegame2.c::3000]:
Askia Mohammad Benkan has been added as Hard level AI-controlled player.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: assertion
'adv->phase_is_initialized' failed.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: Please
report this message at http://gna.org/projects/freeciv/
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (5 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (5 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (2 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (4 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in sg_load_player_city() [savegame2.c::4015]:
City size and number of citizens does not match (3 != 0)! Repairing ...
1: [T219 - 2011/02/09 01:13:28] in city_from_wonder() [improvement.c::563]:
Player Solomon (nb 5) has outdated wonder info for Palace (nb 23), it points
to city nb 136.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
assertion 'city_from_small_wonder(pplayer, pimprove) == pcity' failed.
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]: ( 
47,   29) in "Jerusalem"[3]
1: [T219 - 2011/02/09 01:13:28] in citizens_update() [citizenshand.c::63]:
Please report this message at http://gna.org/projects/freeciv/
2: [T219 - 2011/02/09 01:13:28] in sg_load_players() [savegame2.c::3000]:
Solomon has been added as Hard level AI-controlled player.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: assertion
'adv->phase_is_initialized' failed.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: Please
report this message at http://gna.org/projects/freeciv/
2: [T219 - 2011/02/09 01:13:28] in sg_load_players() [savegame2.c::3000]:
Cofresí has been added as Hard level AI-controlled player.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: assertion
'adv->phase_is_initialized' failed.
1: [T219 - 2011/02/09 01:13:28] in adv_data_get() [advdata.c::732]: Please
report this message at http://gna.org/projects/freeciv/
2: [T219 - 2011/02/09 01:13:28] in sg_load_players() [savegame2.c::3000]:
Attila has been added as Hard level AI-controlled player.
2: [T219 - 2011/02/09 01:13:28] in srv_main() [srv_main.c::2620]: Now
accepting new client connections.


However, on connecting to the game with a client, things look normal
(including the presence of great and small wonders in cities).

There are three classes of warnings in here:
* "assertion 'adv->phase_is_initialized' failed."
** I believe this is bug #17669 and thus irrelevant.
* "City size and number of citizens does not match (8 != 0)! Repairing ..."
** After some thought, I understand this: citizen nationality was enabled in
the experimental ruleset on trunk in patch #2360, but of course my savegame
doesn't have any nationality info, so the server has to invent something.
* "Player Vercingétorix (nb 0) has outdated wonder info for Copernicus'
Observatory (nb 44), it points to city nb 343."
* "Game has outdated wonder info for Copernicus' Observatory (nb 44), the
player Vercingétorix (nb 0) doesn't have this wonder."
* "assertion 'city_from_great_wonder(pimprove) == pcity' failed."
** I think these all come from the following call tree:
*** sg_load_player_cities()
*** sg_load_player_city()
*** citizens_update()
*** sanity_check_city()
*** check_city_good()
*** city_from_great_wonder() or city_from_small_wonder()
*** city_from_wonder()
*** player_city_by_number()
** I think the issue is that we call player_city_by_number() which calls
idex_lookup_city() before the city has been added to the idex hash, since that
happens in sg_load_player_cities() after sg_load_player_city() returns.
** Probably citizens_update() shouldn't call sanity_check_city() (or
refresh_city()?) during loading, as the city is not yet sane. (Or the city
loading shouldn't call citizens_update()?)

More generally, is the second point something the new backward-compatibility
stuff in savegame2.c should be dealing with? We know we're loading a 2.3.0
savegame, so we know it can't possibly have any nationality info, so we could
quietly invent some in the relevant function dispatched by sg_load_compat().

(Off-topic but: have I missed the point of sg_load/save_compat()? At this
stage of trunk development, I'd expect compat_load/save_020400() to still be
empty stubs, and compat_load/save_020300() to be accruing backward
compatibility code, but the opposite is true. Doesn't that mean that new
features won't be being saved by trunk servers by default?)



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Wed Feb  9 01:40:45 2011  Name: freeciv-T0219-Y01595-manual.sav.bz2 
Size: 67kB   By: jtn
Experimental savegame from S2_3
<http://gna.org/bugs/download.php?file_id=12350>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?17678>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to