Follow-up Comment #55, bug #18835 (project freeciv):
I did found an small bug in the patch - there is an unused variable, which is
fixed in this updated version of the 3rd file.
> Likely unrelated, but as this patch dropped mnemonics in a few places, why
is it
> still calling gtk_image_menu_item_new_with_mnemonic or setting
> "use-underline" there ?
I will check this.
> As for the gtk3 warnings, initially I thought it's something regarding the
length of
> the labels, but now I think it might be related to the size of the flags -
but that's still
> a guess.
OK; but is seems to be nothing dangerous.
> On gtk3 warnings topic: ever since 3.2.2, there's a new compile warning for
the
> dialog construct freeciv is using - now gtk_dialog_new_with_buttons wishes
for
> at least one button and a proper NULL sentinel.
The gtk version I use is 3.2.1 (opensuse 12.1). I will have to wait till a
rpm package for the next version is ready.
(file #14664)
_______________________________________________________
Additional Item Attachment:
File name: 0002-gtk3-redo-layout-of-the-diplomacy-dialog-vertical.patch
Size:22 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?18835>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
