URL: <http://gna.org/bugs/?19585>
Summary: get_city_min_trade_route() doesn't work if city has less than max routes Project: Freeciv Submitted by: cazfi Submitted on: Mon 26 Mar 2012 05:08:02 PM EEST Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.3.3, 2.4.0, 2.5.0 _______________________________________________________ Details: get_city_min_trade_route() assumes that all the traderoute slots contain real traderoute. So far this has been true for all callers, but I still want to fix this (make things more robust) in stable branches too. In trunk + patch #3178 this caused crashes as route with NULL city was returned as the one producing least revenue. Fix attached. _______________________________________________________ File Attachments: ------------------------------------------------------- Date: Mon 26 Mar 2012 05:08:03 PM EEST Name: MinRouteFix-S2_4.diff Size: 830B By: cazfi <http://gna.org/bugs/download.php?file_id=15426> ------------------------------------------------------- Date: Mon 26 Mar 2012 05:08:02 PM EEST Name: MinRouteFix.diff Size: 830B By: cazfi <http://gna.org/bugs/download.php?file_id=15425> _______________________________________________________ Reply to this item at: <http://gna.org/bugs/?19585> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev