URL:
<http://gna.org/bugs/?20555>
Summary: Client fails to kill server when it fails to get
'hack' access
Project: Freeciv
Submitted by: jtn
Submitted on: Sun Feb 24 13:10:31 2013
Category: client
Severity: 2 - Minor
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: Any
Planned Release:
_______________________________________________________
Details:
Noted in bug #18467 ("bug 2"):
If the client's handle_single_want_hack_reply() finds that hack is denied for
some reason, it says "Failed to obtain the required access level to take
control of the server. The server will now be shutdown." But the server is not
shut down.
I think this is because client_kill_server() tries to do "/quit" if the
connection to the server is still up. But "/quit" requires hack access...
I think it would be sufficient to add a "client_has_hack" test in
client_kill_server(), which will push it down the process-kill path. (But I
haven't tested it.)
(Also the message should probably say "attempting to shut down", as if you
didn't get hack you might not be able to shut it down either, say if you've
somehow connected to a server you didn't start.)
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?20555>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
