URL:
<http://gna.org/bugs/?20720>
Summary: Transport allied cargo check doesn't recurse
Project: Freeciv
Submitted by: jtn
Submitted on: Sat Apr 6 23:08:12 2013
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: Any
Planned Release: 2.4.0,2.5.0
_______________________________________________________
Details:
Noticed in passing: in unit_move_handling() there's a check when moving
transporters that we're not moving allied cargo from A onto a tile containing
units/city from ally B where A and B aren't allied. However, it only checks
for immediate cargo, not nested cargo.
Tested with attached (trunk) savegame. Illegal move is allowed, and then on
turn done, we get some assertion failures from the server.
1: in srv_running() [srv_main.c::2330]: assertion
'pplayers_allied(unit_owner(punit), unit_owner(punit2))' failed.
1: ( 39, 29) at "Ocean"
1: in srv_running() [srv_main.c::2330]: assertion
'pplayers_allied(unit_owner(punit), unit_owner(punit2))' failed.
1: ( 39, 29) at "Ocean"
1: in begin_turn() [srv_main.c::881]: assertion
'pplayers_allied(unit_owner(punit), unit_owner(punit2))' failed.
1: ( 39, 29) at "Ocean"
1: in begin_turn() [srv_main.c::881]: assertion
'pplayers_allied(unit_owner(punit), unit_owner(punit2))' failed.
1: ( 39, 29) at "Ocean"
1: in begin_phase() [srv_main.c::948]: assertion
'pplayers_allied(unit_owner(punit), unit_owner(punit2))' failed.
1: ( 39, 29) at "Ocean"
1: in begin_phase() [srv_main.c::948]: assertion
'pplayers_allied(unit_owner(punit), unit_owner(punit2))' failed.
1: ( 39, 29) at "Ocean"
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Sat Apr 6 23:08:12 2013 Name: alliance-units.sav.bz2 Size: 14kB By:
jtn
trunk savegame for testing allied cargo cases
<http://gna.org/bugs/download.php?file_id=17690>
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?20720>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
