Follow-up Comment #4, patch #5918 (project freeciv):
if (effect_cumulative_min(boolean_effects[i], NULL) < 0
&& effect_cumulative_max(boolean_effects[i], NULL) >= 0) {
Shouldn't the second test be "=="?
This disables the following construct, which I think should be legal (if
unnecessary):
[effect_transform]
type = "Transform_Possible"
value = 1
reqs =
{ "type", "name", "range"
"Tech", "Fusion Power", "Player"
"UnitFlag", "Transform", "Local"
}
[effect_transform2]
type = "Transform_Possible"
value = -1
reqs =
{ "type", "name", "range"
"Terrain", "Mountains", "Local"
}
(Another doubt I had was that effect_cumulative_min()/max() have the general
problem that they can produce too-large values in some cases of
mutually-exclusive requirements; but that doesn't actually matter for this
specific case, so this usage is fine.)
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?5918>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
