Follow-up Comment #4, bug #23997 (project freeciv):
Trying to work out how to describe this for release notes, I noticed another
similar instance further down the function (S2_5):
if (best_unit_type) {
if (!walls && !utype_has_flag(best_unit_type, UTYF_BADCITYDEFENDER)) {
best *= city_data->wallvalue;
best /= POWER_FACTOR;
}
Can that not suffer the same problem?
(There's a similar one a bit further up
/* Contrary to the above, we don't care if walls are actually built
* - we're looking into the future now. */
if (!utype_has_flag(punittype, UTYF_BADCITYDEFENDER)) {
desire *= city_data->wallvalue;
desire /= POWER_FACTOR;
}
but maybe there's some reason wallvalue can never be 0 in that case?)
(My best guess for release notes: "Rulesets with unusual uses of the
Defend_Bonus effect could cause the AI not to desire building defensive
units.")
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?23997>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
