Follow-up Comment #5, bug #24135 (project freeciv):
> a longstanding latent issue
Not necessarily. For optimization reasons the semantics of the extremely often
called is_valid_dir() was changed. Previously directions falling outside of
the valid range were also handled there (returning that such a direction is
NOT valid). Now it assumes (with the assert(), when asserts enabled) that
caller knows not to pass direction8_invalid() to it.
Maybe 2.5.2 solution is to replace the assert with a normal check and
returning FALSE for invalid ones?
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24135>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
