URL:
<http://gna.org/patch/?6769>
Summary: Include <winsock2.h>, not <ws2tcpip.h> to fcthread.h
Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 01 Jan 2016 01:18:41 PM EET
Category: bootstrap
Priority: 5 - Normal
Status: Ready For Test
Privacy: Public
Assigned to: None
Originator Email:
Open/Closed: Open
Discussion Lock: Any
Planned Release: 2.6.0, 3.0.0
_______________________________________________________
Details:
fcthread.h needs to include <winsock2.h> just to make sure it doesn't include
<windows.h> before some source file including it has included <winsock2.h>. So
include just <winsock2.h>, not <ws2tcpip.h>.
There's also wider problem of unnecessary <ws2tcpip.h> includes, resulting
from the fact that they were added before <winsock.h> vs <winsock2.h>
resolution that makes <winsock2.h> includes sort of necessary even when
<ws2tcpip.h> is being included. This particular case differs from the (or most
of) other ones in that there's *only* the <ws2tcpip.h> include that should be
only <winsock2.h> include. The other cases have both of them included, making
<ws2tcpip.h> include redundant in most cases.
_______________________________________________________
File Attachments:
-------------------------------------------------------
Date: Fri 01 Jan 2016 01:18:41 PM EET Name: Winsock2HdrThread.patch Size:
940B By: cazfi
<http://gna.org/patch/download.php?file_id=26228>
-------------------------------------------------------
Date: Fri 01 Jan 2016 01:18:41 PM EET Name: Winsock2HdrThread-S2_6.patch
Size: 908B By: cazfi
<http://gna.org/patch/download.php?file_id=26229>
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?6769>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
