URL:
  <http://gna.org/patch/?6842>

                 Summary: Do not include netintf.h to mapimg.c
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Fri 22 Jan 2016 10:50:27 PM EET
                Category: general
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.5.3, 2.6.0, 3.0.0

    _______________________________________________________

Details:

Include of netintf.h has been in mapimg.c from the beginning -> it has not
been added when it has been required. Mapimg should have nothing to do with
networking, and as it compiles fine without, attached patch removes the
include.

If there's one "blindly" added include there, it's quite possible that some of
the other includes are unnecessary too. Feel free to investigate that, but I'm
now interested about removal of this more troublesome include contributing to
the networking code mess.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Fri 22 Jan 2016 10:50:27 PM EET  Name: MapimgNetHdrNot.patch  Size: 369B
  By: cazfi

<http://gna.org/patch/download.php?file_id=26424>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?6842>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to