URL:
  <http://gna.org/bugs/?24473>

                 Summary: Unnecessary multiplication by zoom in
gui_rect_iterate()?
                 Project: Freeciv
            Submitted by: jtn
            Submitted on: Sat 27 Feb 2016 10:05:05 PM UTC
                Category: None
                Severity: 3 - Normal
                Priority: 5 - Normal
                  Status: None
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
                 Release: 
         Discussion Lock: Any
        Operating System: Any
         Planned Release: 

    _______________________________________________________

Details:

Looking at trunk gui_rect_iterate() I noticed a couple of lines of the form


if (tileset_hex_width(tileset) * _zoom > 0) {
  /* ... */
}


I don't think the multiplication by _zoom is necessary, since this is just a
test for zero? If so we can save some cycles.

So-far-untested trunk patch attached. Feel free to steal ticket.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 27 Feb 2016 10:05:05 PM UTC  Name: trunk-gui-rect-hex-zoom.patch 
Size: 995B   By: jtn
trunk r32097
<http://gna.org/bugs/download.php?file_id=26882>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?24473>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to