URL:
<http://gna.org/bugs/?24665>
Summary: unit_move_handling() callers not setting
move_diplomat_city correctly
Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 12 May 2016 04:54:02 PM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release:
Contains string changes: None
_______________________________________________________
Details:
1) move_diplomat_city parameter should be renamed as it's now generic (move in
instead of doing adjacent activity) marker, not specific to diplomats
2) I think some callers are not properly adjusted to its new meaning, but
still assume it to be meaningless when the unit being moved is not a diplomat
For example, attack of an AI unit might be prevented by the fact that the unit
could do some activity and the caller has not set move_diplomat_city to mean
that it wants to move in to the city to conquer it.
The AI and move_diplomat_city checks should probably take place before
calculating all the potential activity targets etc. Maybe even as an outer
block to
if (utype_may_act_at_all(unit_type_get(punit)) {
}
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24665>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
