Christian Knoke wrote: > OED says: PHRASES in the field 1 (of troops) engaged in combat or manoeuvres > 2 engaged in practical work in the natural environment. ... - ORIGIN Old > English. > > ... > > So, FieldUnit is wrong and confusing. What about AirAttackUnit? > How about F_AGGRESSOR?
Actually, there are a lot of badly named flags, or flags that are only true in one ruleset, or flags that are just plain incomprehensible without studying the code (no comments in the definition).... F_IGZOC, F_IGTER, Huh? F_SETTLERS, /* Does not include ability to found cities */ That should be F_WORKERS. F_TRIREME, /* Trireme sinking effect */ That should be F_COASTAL -- in the current 2.2, it no longer sinks, and for civ3+, isn't even named "trireme". And of course, the flag names and their help should be in rulesets! > Instead, we can use the term 'field unit' for "military units away from > home". > Sounds good. >> [Don't know is it able to set F_FIELDUNIT with F_CIVILIAN (non-mil).] > Any combination can be set, doesn't mean they make any sense! See list: common/unittype.h:81: F_FIELDUNIT, > Where is F_CIVILIAN? I can't find it in 2.1 or 2.2. > common/unittype.h:75: F_CIVILIAN, client/helpdata.c:998: "* A non-military unit (cannot attack; no martial law).\n" _______________________________________________ Freeciv-i18n mailing list [email protected] https://mail.gna.org/listinfo/freeciv-i18n
