All: First, let me thank all the developers for a great game - on a whim, I just pulled down the source (rev. 10401) and played for the first time in almost a year, and I have to say that the improvement since I last tried FreeCol was amazing. For the first time in my recollection, I was able to play the whole game without a server reconnect (at least a visible one) or bugs that affected game play in a noticeable way.
I did notice a few minor issues while I was playing, however, and despite my Java skills being quite rusty (haven't really used them since getting my CS degree 13 years ago :)), I decided to try to see if I could contribute fixes. Attached is a patch to address the first of them, namely that fortresses do not seem to require a minimum population of 8, as I recall was the case in the original game and is actually the documented behavior in the FreeCol user guide. As it turns out, the fix is only a single change to specification.xml, although I added some unit tests to verify the behavior (as well as the minimum population of 3 for stockades and forts, just for good measure). Hopefully my lack of experience with Java and this codebase doesn't leave the patch a stylistic wreck, but in any event, the actual fix should be easy enough to port directly into your working copy if you'd prefer to do it that way. Thanks again for the fun game, and hopefully I'll have a few more minor fixes over the coming days. (Which means that if you'd prefer I just post the patches directly to the SF tracker, just let me know.) Happy New Year! -Russell
fortress_should_require_population_8.diff
Description: Binary data
------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
