On 07.01.2013 10:41, Michael T. Pope wrote: > Last minute scare. In testing I captured a badly located enemy fort > and decided to abandon it. This did not work. The override in the > freecol ruleset to allow abandoning colonies with stockades only > applies to stockades, not forts or fortresses. On reflection this is > not that surprising, as the inheritance from stockade to fort happens > when we read the classic ruleset, and by the time the freecol rules > are read and the stockade override occurs, fort and fortress are > defined with their own copies of the features inherited from stockade. > > A quick check reveals that this has been broken since at least > 0.10.5-release. It is now fixed brutally in svn.10449, just in time > for 0.10.7. I am not sure we can do this much better. We could > explicitly propagate "delete" operations to "extends" targets, but > while we have that information in the case of building types, I am not > sure we record it consistently for all FreeColGameObjectTypes. > > Fortunately, "delete" is a rare operation. > > Cheers, > Mike Pope >
This problem, as well as the movement cost bug, clearly show that our unit tests are not what they should be. Regards Michael ------------------------------------------------------------------------------ Master SQL Server Development, Administration, T-SQL, SSAS, SSIS, SSRS and more. Get SQL Server skills now (including 2012) with LearnDevNow - 200+ hours of step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only - learn more at: http://p.sf.net/sfu/learnmore_122512 _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
