On Sat, 16 Mar 2013 08:07:12 AM Michael Vehrs wrote: > There have been several complaints about the ability to open some panels > or dialogs several times.
Like BR#2141. > In some cases, it makes sense, I think. In > others, not so much. In the distant past, FreeCol had only a single > instance of most panels, all of which were created when the game > started, as far as I remember. We abandoned this approach in order to > gain the ability to switch languages in-game, if I recall correctly. There are cases (e.g. ColonyPanel) where I do not think we should go back there. > This, however, could also be handled by mandating some method to > recalculate all localized strings. Should we return to the singleton > panel design, or should we keep track of open panels and prevent opening > several instances at any one time? Or just use Canvas.getExistingFreeColPanel to see if a panel of the required type is already present? That is what I used to fix BR#2141, preventing multiple instantiation of the bulk of the Report*Panels, as of git. f39127f (last Wednesday). Cheers, Mike Pope
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
