On Wed, 24 Apr 2013 08:20:40 AM Michael T. Pope wrote: > On Tue, 23 Apr 2013 04:19:06 PM Thue Janus Kristensen wrote: > > I loaded a save game in the latest freecol git. I could not move > > colonists between buildings; the colony is not editable. > > > > In a new game it works fine. > > > > The following fixes it. A better fix is probably to find out why players > > exist in two copies. > > I have not seen any cases where players are duplicated. The real cause here > remains unclear.
The cause has emerged (BR#2545 had it too). I expect the saved game was in debug mode? > > colony.getOwner() is a serverplayer object, while getMyPlayer() > > returns a player object. > > I doubt it. If you are running ColonyPanel code, you are inside the client > thread, which does not contain any ServerPlayers. ...because in single player debug mode, the colony being displayed is the *server* colony, and its owner is therefore a ServerPlayer. So it turns out that your fix was exactly right, and has been applied (git.2f89727). Cheers, Mike Pope
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Try New Relic Now & We'll Send You this Cool Shirt New Relic is the only SaaS-based application performance monitoring service that delivers powerful full stack analytics. Optimize and monitor your browser, app, & servers with just a few lines of code. Try New Relic and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers