On 25.08.2013 11:29, Michael T. Pope wrote: > On Sun, 25 Aug 2013 10:24:16 +0200 > Michael Vehrs<michael.bursc...@gmx.de> wrote: > >> I have gathered a list of unit labels, as used by FreeCol and the >> original game, as far as I can determine. The entry for Free Colonist is >> representative for all unit types that represent people with no expert >> role, the entry for Caravel is representative for all unit types that do >> not represent people... >> >> ...Things get complicated when the unit has more than one expert role, as >> is the case with veterans, continental regulars, king's regulars, and >> possibly braves. I see no way to generalize these labels, so we should >> probably just check for the presence of corresponding keys in the >> messages file. >> >> In the case of a unit with a proper name, I think we should put the name >> first, followed by the label, like this: >> >> Santa Maria (Spanish Caravel) >> Natty Bumppo (English Seasoned Scout/no horses) >> The Gold of El Dorado (Spanish Treasure Train/5000 gold) >> >> That is, if the label already contains parentheses, replace them with >> slashes. >> >> What do you think? >> > That is better than where we are, but looks fiddly to implement, however > this is important enough an issue that we should be trying to follow Col1. > So I would like to leave it to you as the resident expert in > StringTemplate:-). Most of the parts are there, except that nation is > definitely required in this format. > > Cheers. > Mike Pope >
As it turns out, it was a bit trickier than I thought. Still, I have committed a first implementation of the new unit label. It causes another label-related test to fail, since I had to eliminate some special case string templates from the messages file. Still, that error should go away if we cut over to the new implementation. Regards Michael ------------------------------------------------------------------------------ Introducing Performance Central, a new site from SourceForge and AppDynamics. Performance Central is your source for news, insights, analysis and resources for efficient Application Performance Management. Visit us today! http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
