On Mon, 09 Sep 2013 17:11:38 +0200 Michael Vehrs <michael.bursc...@gmx.de> wrote: > True, of course. What you want is JDialog, which can be modal, but > doesn't have to be, but you can't (or at least shouldn't) use JDialog if > you are using JDesktopPane. This situation, which seems like a strange > oversight of the Java designers, allows for two solutions. We can either > abandon the desktop pane, or re-implement (most of) JDialog on the basis > of JInternalFrame, which is basically what we have done with > FreeColDialog. The problem here being that we haven't done it right.
Well said. I think the latter is preferable, but am not fully convinced either way. So as a first step I am doing an audit of our use of dialogs to see if we can at least narrow the problem. There are low-hanging fruit. ErrorPanel, EventPanel and InformationDialog are instances of FreeColDialog<Boolean>, but the result is ignored. I will convert these to derive from FreeColPanel. The next obvious category are dialogs that do not really need to be modal. Many of the uses of showConfirmDialog are asking pretty critical questions (e.g. reconnect, quit, etc). These could be vanilla JOptionPanes. So, a bit of preparatory work to do before we have to make the harder decision. Cheers, Mike Pope
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ How ServiceNow helps IT people transform IT departments: 1. Consolidate legacy IT systems to a single system of record for IT 2. Standardize and globalize service processes across IT 3. Implement zero-touch automation to replace manual, redundant tasks http://pubads.g.doubleclick.net/gampad/clk?id=51271111&iu=/4140/ostg.clktrk
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
