Hi all,

I took a look at the pdf and there are a few things I feel should
be changed.
Like the others I think you better describe how different ant targets work.
At least tell to use "ant clean" for safety from moving/adding/removing
sourcefiles, before doing "ant". 
"ant testall" and "ant run", maybe "ant prepare-commit" are also worth 
mentioning,
although I prefer "java -Xmx256M -jar FreeCol.jar --log-level finest". With the 
new
version "--windowed" is not needed anymore, but you could tell about 
"--fullscreen"
and variants of "--windowed" with window size.
You seem to tell just running the jar, but depending on OS version and how Java 
was
installed you may need to explicitly start java in the shortcut (or better 
javaw in a
shortcut on Windows to not have a terminal window, though in terminal you should
use java without w).
I dont like how you make it look like git extensions was a mandatory 
requirement,
when all you need is git and git extensions is just your favorite gui tool for 
git.
At git-scm.com you can get git for all OS and the Windows version includes 2
explorer extensions you can choose and git bash already. Telling which install 
options
to choose would be nice.
Also you could mention other gui tools, for example, github program.
Keeping the guide cross-platform would be better btw. than only telling about 
Windows.
Possibly mention the bundled JDK with NetBeans, as it includes ant already 
inside
a subdirectory of the installation and although I dont like the git addon inside
NetBeans, using that would also be an option.
For basic editing a simple editor like Notepad++ is much easier to use, but not 
sure
if you aim at strictly end users or also beginner contributors with the guide.

Greetings,
wintertime


> Gesendet: Dienstag, 06. Januar 2015 um 11:53 Uhr
> Von: LoneVVolf <lonew...@xs4all.nl>
> An: freecol-developers@lists.sourceforge.net
> Betreff: Re: [Freecol-developers] Compiling FreeCol PDF Resource
>
> On 06-01-15 08:22, Michael T. Pope wrote:
> > On Mon, 5 Jan 2015 23:36:12 -0500
> > Caleb Williams <cale...@gmail.com> wrote:
> >> I have attached it and I'd appreciate your thoughts, whatever
> >> they may be.
> > I can not really comment on much other than Appendix B, which is to the
> > point and accurate.  The only change I would make is to emphasize even
> > more that bug reports should be reproducible.
> >
> > Cheers,
> > Mike Pope
> 
> I agree with Mike about more emphasis on reproducible bug reports.
> 
> Also i think a bit more detail wrt the ant command  would be useful .
> some examples :
> a. show the command used to build freecol releases
> 
> b.   ant -projecthelp    -  list all possible targets for building freecol
> 
> c. ant supports many special variables that can be set from command line
> f.e if you want to force freecol to build against a specific version of 
> java, use this :
> ant -Djava.target.version=1.8
> 
> LVV
> 
 

------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to