On Thu, 6 Aug 2015 16:00:43 +0200 win...@genial.ms wrote: > > I have been working on the client IGC and the way it sets the active unit > > and > > interacts with the GUI in general. The patch is now fairly intrusive so I > > have held it up for some play testing. > > Well, if you would have attached a diff, I could take a look at it or > try it out.
Its still too flakey, and does not yet include any proposed code to fix what I discuss below. > > One important oddity is that when we > > move a unit there is the following: > > > > if (!gui.onScreen(tile)) gui.setSelectedTile(tile); > >... > > It might be better to not change the selected tile, but not sure if > changing that causes the screen to some weird long unvisited part > of the map when switching to the tile view mode? Yes, that might be a problem. I will experiment. > I think we have several methods already, which could provide that > functionality. Maybe setFocus, setFocusImmediately, centerActiveUnit, > isTileVisible, onScreen or some others in MapViewer would help? > But the call should be routed through SwingGUI and there are some > helper methods already. OK, I missed centerActiveUnit, that sounds promising. > > BTW, terrain mode is working again for me following git.5f978b. I > > updated the wiki. > > Was it that commit or did git.c039176c fix it already? No idea. I only had a chance to try it again yesterday, when the commit referenced was the last relevant one. Cheers, Mike Pope
pgpGfWCDoVykb.pgp
Description: OpenPGP digital signature
------------------------------------------------------------------------------
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
