Hi, > Gesendet: Mittwoch, 12. August 2015 um 13:01 Uhr > Von: "Michael T. Pope" <mp...@computer.org> > An: freecol-developers@lists.sourceforge.net > Betreff: Re: [Freecol-developers] Updating audio and video players > > >[fonts] > > Further to the fonts discussion, I have now done a bit more play testing > with just Imperator restored. My conclusion is that it is also less > readable, and not sufficiently interesting or distinctive to persist with. > Does anyone really want it?
I'd say removing them from the base resources should be done. We could move them into a trivial new mod, which just overwrites the 2 resource keys and contains the fonts. I'm not sure if thats useful. The code I wanted to add for checking if strings are compatible with the font will take a bit longer. I could easily hack it in on all call sites, but I don't like that solution, as it would often need to extract the string from a JLabel, which was just created inside Utility together with the Message call to translate it. These Utility methods look trivial, almost tempting to get inlined, because there is a huge amount of overloads already and I might need to triple that amount. I'm thinking of adding some more methods to FontLibrary first, which take the string and use the font type parameter only as a hint to find the best match upon the 3+1+1 choices. While looking at Utility I felt I had found some inconsistency with the Message handling. Sometimes there is a direct call to Messages.message(stringkey) and other times Messages.message(StringTemplate.key(stringkey)). They seem equivalent to me, but the first trims the string, the second does not. Do you know why? Could that trim call be removed? Greetings, wintertime ------------------------------------------------------------------------------ _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
