In Eclipse, the rewrite git.e1d318a looks okay for the IDE. I must admit, this version is more readable than mine or the original one. Thank you, Mike
Fiisch 2016-05-05 12:47 GMT+02:00 Petr Fišer <pries...@gmail.com>: > Hi, > Keeping the convention is definitelly a valid reason and I would > rather use another IDE than make you to break code style. > Perhaps, this is more a case for Eclipse devs to tweak up their code helper. > :) > > The main thought behind the patch was to ease development for others > and Eclipse was a good choice. Perhaps IntelliJ could do the trick. > What do you use? > I'll check git.e1d318a when I get home. > > Regards, > Fiisch > > 2016-05-04 10:51 GMT+02:00 Michael T. Pope <mp...@computer.org>: >> On Sun, 1 May 2016 21:04:01 +0200 >> Petr Fišer <pries...@gmail.com> wrote: >>> I'm pretty used to Eclipse IDE but when I tried to get git.1756c04 >>> working, IDE complained about type safety on some things in >>> ChooseFoundingFatherMessage.java. >> >> Your patch is clearly correct. OTOH, Eclipse is clearly wrong to require >> it as the java compiler has no difficulty with the original code. I broke >> up the expressions a bit in git.e1d318a, can you see if that satisfies >> Eclipse? >> I would prefer not to break the convention of always using a static import >> of modules from .../common/utils. >> >> Cheers, >> Mike Pope ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
