On Fri, 23 Dec 2016 12:42:11 +0100
Arnaud Blouin <blouin.a...@gmail.com> wrote:
> Strange, I cannot comment my merge request.
> 
> I replaced the tabs by spaces as required.

Cool.  Will look at it again in a few days time.
 
> Mike, thanks for your quick feedback. When you say that the refactoring
> is an improvement, what does it improve for you?

I like it when the code for defining a UI element and the code for
interacting with it are close together.  So hauling code out of the action
listener routine and into a lambda next to the point a button is defined
is an obvious win for me.  OTOH, I like lambdas (old Lisp hand here).
Others are less convinced.

I also like shorter code.  Mostly.

> Also, when you say that "Interface complexity is the #1 menace.", I
> guess you are talking about the number of widgets that can compose a
> user interface,

Partly.  Also number of different classes involved, and especially the
interactions between the classes... however that is a slippery concept ---
I have seen cases where blindly reducing the cyclomatic complexity made
a codebase harder to read/understand.

> the difficulty to use user interfaces?

I am thinking mainly from the code development side.  I try to keep out of
UI design / usability.

Cheers,
Mike Pope

Attachment: pgpTjRNL6jTte.pgp
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today.http://sdm.link/intel
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers

Reply via email to