From: "Enrico Weigelt, metux IT consult" <enrico.weig...@gr13.net>
FreeColModFile.getModsList() always creates a new list anyways, so no need to create a copy of its result. --- src/net/sf/freecol/common/option/ModOption.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/net/sf/freecol/common/option/ModOption.java b/src/net/sf/freecol/common/option/ModOption.java index 975b3acf281..d8888437d4c 100644 --- a/src/net/sf/freecol/common/option/ModOption.java +++ b/src/net/sf/freecol/common/option/ModOption.java @@ -61,7 +61,7 @@ public class ModOption extends AbstractOption<FreeColModFile> { * @return A list of {@code FreeColModFile}s. */ public final List<FreeColModFile> getChoices() { - return new ArrayList<>(FreeColModFile.getModsList()); + return FreeColModFile.getModsList(); } -- 2.11.0.rc0.7.gbe5a750 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers