On 02.02.2017 22:05, win...@genial.ms wrote: > I wanted to try it out to possibly apply it, but when I > copied the patch into a file and used git apply, I got: > "error: corrupt patch at line 11" although it did > not look corrupted to me?
Looks like it something broke the mail path or copying it out. Perhaps just cherry-pick from here: https://github.com/oss-qm/freecol/tree/SUBMIT_panel_esc > From what I see it would couple the esc key in all panels > with the ok button, but some might also have a cancel button, > which is the more natural fit for the esc key and having the > key activate ok in that case may confuse users. IMHO, these dialogs already set this key binding on their own, thus overwriting the default my patch introduces. > Though > I'm not sure atm if its only dialogs that have a cancel button > in FreeCol or if theres also some panels. Did you check for this? Should only affect those panels that have an ok button. At least, other panels dont just close on pressing esc. OTOH, of course, we could introduce a flag for that. Maybe even more generalized by some standard buttons attribute, eg. whether we have just ok, or and abort, etc. --mtx ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
