[Freecol-developers] [PATCH] common: model: Player: remove unnecessary check that's always true

[Enrico Weigelt, metux IT consult]

productionType::getOutputs() never returns null
---
 src/net/sf/freecol/common/model/Player.java | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/net/sf/freecol/common/model/Player.java 
b/src/net/sf/freecol/common/model/Player.java
index 1d884626f72..3974bdc3d8a 100644
--- a/src/net/sf/freecol/common/model/Player.java
+++ b/src/net/sf/freecol/common/model/Player.java
@@ -3350,7 +3350,6 @@ public class Player extends FreeColGameObject implements 
Nameable {
             int bestValue = 0;
             for (ProductionType productionType : t.getType()
                      .getAvailableProductionTypes(true)) {
-                if (productionType.getOutputs() != null) {
                     int newValue = 0;
                     for (AbstractGoods output: productionType.getOutputs()) {
                         newValue += market.getSalePrice(output.getType(),
@@ -3359,7 +3358,6 @@ public class Player extends FreeColGameObject implements 
Nameable {
                     if (newValue > bestValue) {
                         bestValue = newValue;
                     }
-                }
             }
             value += bestValue;
             if (nearbyTileIsOcean) {
-- 
2.11.0.rc0.7.gbe5a750


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers