Yeah, the tests need a lot of love. I enabled the simpleMove test purely
for the sake of using the client helper tests. Although those should be
their own tests, I am still learning the system, so haven't created a
client test yet.
At the moment I'm cleaning up and fixing the build.xml file (creating a new
one for the time being) that will be designed to create packages from
Travis and be deployed automatically so we don't have to do any of that
manually. There are a number of dependency issues that need to be solved
before distributions can be made. I've figured out most of the errors, and
now just a matter of cleaning things up. There are a lot of legacy settings
in there.
David
On Thu, Aug 31, 2017 at 3:31 AM Michael T. Pope <mp...@computer.org> wrote:
> On Thu, 31 Aug 2017 00:24:31 +0000
> David Lewis <highwayofl...@gmail.com> wrote:
> > That's odd... it succeeds on my local machine and local build machines
> > (docker containers), and succeeds on the Travis CI build servers (each
> run
> > `ant test`)...
> >
> > There are 2 tests that fail on the remote build nodes: mixer isn't
> > available on build nodes. But I don't see any NPE's.
> > I enabled the simpleMove test, which was disabled, and modified the
> client
> > connect helper significantly because it was broken.
>
> OK, AFAICT the client connect helper is *only* used for testSimpleMove,
> which is suggestive. I do not recall why simple move testing was
> disabled, but I suspect there is some lurking breakage. The test itself
> is a bit lame --- if we were really just testing the simple-move routines
> we could do a lot better job and without starting a client. So if we can
> not sort this out soonish I recommend just disabling it again.
>
> The fact that I am only seeing it on one machine (a new one) which
> otherwise has the same software setup as my usual development box suggests
> some sort of timing effect.
>
> > Can you try doing a clean checkout (or clone new repo) and try again?
>
> OK, when I get back to the machine that shows the failure.
>
> > Which version of of the JDK are you using?
>
> Java vendor: Oracle Corporation
> Java version: 1.8.0_141
> Java WM name: OpenJDK 64-Bit Server VM
> Java WM vendor: Oracle Corporation
> Java WM version: 25.141-b16
>
> Its always whatever the latest release on Fedora is, and thus is
> usually quite up to date.
>
> Looking again at the crash, it seems very entwined with the Locale
> setting, which is weird. I have tightened up the Locale handling
> (git.751b33d), perhaps that will help.
>
> Cheers,
> Mike Pope
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Freecol-developers mailing list
Freecol-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freecol-developers
