On Tue, 14 Dec 2021 14:56:29 +0100 (CET) Stefan Fellner <stefan.fell...@tutanota.com> wrote: > you're right - I should only do one thing at a time. > > I figured it is problematic - so it needs more thorough testing. > > I will try to nail it down one-for-one and describe the (possible) > improvement i see.
Thanks. This area has been a real nuisance, and once again, really easy to break. > > Wrt the second change, I am wondering if we should use hasTile() rather > > than isInEurope() to include the high seas case. > > > So the second change you're right, when the hasTile() includes the HighSeas > case this is even better, I think that's probably not causing side effects. I > changed it, and the patch contains only this one change. I am struggling to think of how this can go wrong, so committed (git.45c2e4be94). What will be different is that in some cases the currently selected tile will now no longer change, which might work better if there is a selectable unit still there. Alas, I have been frequently wrong in this area so let us hope for some good testing. Cheers, Mike Pope
pgp2WpOxi7RTu.pgp
Description: OpenPGP digital signature
_______________________________________________ Freecol-developers mailing list Freecol-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freecol-developers
