EXACTLY! Now I see that put_unsigned() and put_string in prf.obj have a
CBW instruction that does just that! So, what do you suggest? I think that we can just apologise to K&R and change c in put_console() to char.
or cast to unsigned char. That's standard practice just like for is* functions. Well the idea of this is that getchar() returns int() so you would keep a single character read from a file in an int. With a special value being EOF (usually -1, but just has to be negative in general).
Yes, and they extended this practice to putc[har] as well which returns EOF on error. But our put_console returns nothing so we don't have to follow this practice with it.
In our case put_console can just as well take unsigned char since it doesn't deal with EOF.
OK, so I'd prefer changing the c type to unsigned char then. It could be just char but it's better to be unsigned char indeed to emphasize that 8-bit characters are valid too.
Lucho
------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ Freedos-kernel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freedos-kernel
