Hi!
______________O\_/_________________________________\_/O______________
case 0x03:
{
struct buffer FAR *bp;
bpb FAR *bpbp;
DWORD newmirroring =
xdffp->xdff_f.setmirroring.newmirroring;
if (newmirroring != -1
&& (ISFAT32(dpb)
&& (newmirroring & ~(0xf | 0x80))))
_____________________________________________________________________
O/~\ /~\O
1. Condition here may be reformated:
if (newmirroring != -1 &&
(newmirroring & ~0x8f) &&
ISFAT32(dpb))
2. newmirroring is a DWORD, but ~0x8f is a unsigned. If should be checked
only low word of newmirroring, then this code may be optimized:
... && ((unsigned)newmirroring & ~0x8f) && ...
else 0x8f should be casted:
... && (newmirroring & ~0x8fl) && ...
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
Freedos-kernel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel
