Hi!
13-Июн-2004 19:39 [EMAIL PROTECTED] (Bernd Blaauw) wrote to
[EMAIL PROTECTED]:
BB> Eric and I have been working a few hours on a patch to correct the
BB> ask-user-to-execute-config.sys-line algorythm.
BB> essentially (config.c, line 806 I think):
BB> /* !device= never ask / device?= always ask / device= ask if singleStep */
BB> /* "!" does override singleStep but not "?", so "!device?=" will ask... */
As I understand, currently behavior is this:
- "123?" present and statement not from selected menu? Skip.
- "!" present? Don't skip.
- "?" present or single step? Ask.
Your proposal changes behavior: now it will look so:
- "123?" present and statement not from selected menu? Skip.
- "?" present? Ask.
- single step and not "!" present? Ask.
I think, this is valid.
BB> if (! ( (singleStep && !DontAskThisSingleCommand) ||
BB> (askThisSingleCommand) ) )
BB> return FALSE; /* do not skip, and do not ask either */
This is identical to (simpler):
if ((!singleStep || DontAskThisSingleCommand) &&
!askThisSingleCommand)
return FALSE; /* do not skip, and do not ask either */
but I think this better will look so:
if (!(askThisSingleCommand || /* "?" */
singleStep && !DontAskThisSingleCommand)) /* not "!" */
return FALSE; /* do not skip, and do not ask either */
Well... I hardly rework config.c and fix many bugs (most of them are "not
check input validness" - for example, "break=offk" accepted as "on"). Also I
add above your changes. If you wish/can/may, I send you my config.c for
testing.
-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND
_______________________________________________
Freedos-kernel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel
