Arkady, Bart, > BO> -void _seg * KernelAllocPara(size_t nPara, UBYTE type, CStr name, int mode) > BO> +void _seg * KernelAllocPara(size_t nPara, UBYTE type, const char *name, int > BO> mode) > > This is example, how my shortcuts allows to shorter and, thus, more > redable lines.
No, Bart is perfectly right. If you use CStr, I first have to lookup what CStr means. It is no "obvious" name for const char *! This actually INCREASES the problems with reading code, unless you first learn all defines by heart. UBYTE on the other hand, for example, is a very obvious name for something which is not signed and 8 bits big. So please do use "Bart style" again. I admit that I have suggested CLUSTER for some 32bit values in FAT32 kernels, but I think that far more people know that FAT32 cluster numbers are 32 (28+4 actually) bit values. Nobody knows what CStr is without searching for the typedef. > Well... Changes are arrive and arrive... Do you will upload some > archive, which may be downloaded and all your changes may be compared with > my tree? This is EXACTLY what I would want YOU to do! It would be great if you, Arkady, could upload a collection of all patches, plus a big text file which tells us exactly which patch fixes / changes / optimizes / comments what, and which patches must be used in conjunction (e.g. one dsk.c patch must be used in conjunction with a corresponding DF_NOACCESS fix). This would make it much easier to review your patches and design which of them are important / fix bugs and which "only" improve comments / reduce kernel size. "Changes arrive and arrive" is a very good description for your patches as well, and it is hard to keep an overview if they are all spread around and hidden between dozens of mailing list mails. And you cannot "unzip all patches to a directory and then browse then to understand them and select the best ones" either, if looking at every single patch requires finding back the right mail in the archives. Thanks ;-). Eric. ------------------------------------------------------- This SF.Net email is sponsored by BEA Weblogic Workshop FREE Java Enterprise J2EE developer tools! Get your free copy of BEA WebLogic Workshop 8.1 today. http://ads.osdn.com/?ad_id=4721&alloc_id=10040&op=click _______________________________________________ Freedos-kernel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/freedos-kernel
