Hi!
5-Янв-2005 09:19 [EMAIL PROTECTED] (Pat Villani) wrote to
[email protected]:
PV> The "-" in the diff says that the break is removed entirely. Did you
PV> actually mean this, given your reply?
Yes. Break is removed, but later some new developer may wonder, "why
there are no `break'?". So, I suggest, better to remain `break' in place, or
replace it by consequent comment (like there is commented other `break'
missings - see "/* fall through */" comments).
Of course, advanced developer later spends his time and teaches itself,
that "return_user()" is never returns, but before this he will be in
trouble.
PV> I think you do save 2 or 3 bytes per break, depending on the compiler.
`Break' is a jump, so removing `break' may reduce code, but if there
are similar tails above removed `break's, then you (may) lost in size,
because those tail now can't be joined (at least, if you can't instruct
compiler, that last function call never returns).
PV> However, I can relate to you an amusing experience. At one time, I did
PV> some consulting for Bell Labs. A few years after I left, AT&T had a
PV> major network failure in the northeast US. A friend who was still with
PV> AT&T told me that the failure was the result of a hardware problem that
PV> took the code into an untested branch of code. It was a function call
PV> inside a case that should have never returned and had no break at the
PV> end. The code fell into the next case and the system fell like a set
PV> dominoes.
:) We can't protect from such hardware failures (when executed random
pieces of code). :(
PV> I'm not maintaining the kernel, so just my $0.02 -- which is worth less
PV> in Euros ;-)
-------------------------------------------------------
The SF.Net email is sponsored by: Beat the post-holiday blues
Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek.
It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt
_______________________________________________
Freedos-kernel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel
