On Wed, 5 Jan 2005, Peter Fedorow wrote:
--cut--OmmitIfOptimizeSize break ();
Very hard to justify such macros, then you may as well use a comment, the potentially nasty fallthrough would still be there in the "embedded case".
A macro will allow all such cases to be turned on and off at once. This probably won't be the last optimization of a few bytes in one place that can have a nearly, but not absolutely imposible downside.
A more accurate name for the macro would probably be OmmitIfOptimizeSizeExtreme, but I think that might be getting rediculously long. Perhaps someone has a better name for it?
The define to turn on and off the constant controlling the macro should definately be well commented. Perhaps something like, "Only use if you have to save every last byte. In the event of a really bad internal error you won't get a useful error."
IMHO if you really want to save space for embedded stuff you should selectively remove features (e.g. FAT12 or FAT32, LBA, FCB stuff, whatever). Those in the business hopefully make money of their embedded stuff, and they are free to make such modifications; they should not prey to the kernel developers to do it.
Are embedded developers welcome to send in clean patches to selectively remove those items?
------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Freedos-kernel mailing list Freedos-kernel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/freedos-kernel
