Hi, what do you think about the following patch:
--- config.c (Revision 1354)
+++ config.c (SUGGESTED)
@@ -1918,16 +1918,16 @@
printf(" (Selection=%d) ", MenuSelected);
if (MenuTimeout >= 0)
- printf("- %d \b", MenuTimeout);
+ printf(" %d \b", MenuTimeout);
else
printf(" \b\b\b\b\b");
if (MenuColor != -1)
printf("\r\n\n ");
else
- printf(" -");
+ printf(" ");
- printf(" Singlestepping (F8) is: %s \r", singleStep ? "ON " : "OFF");
+ printf(" Singlestepping (F8) is %s \r", singleStep ? "ON " : "OFF");
key = GetBiosKey(MenuTimeout >= 0 ? 1 : -1);
Background: The current menu line with non-full-screen menu is:
Select from Menu [012], or press [ENTER]- 2 - Singlestepping (F8) is: OFF
This is too long - if you have too many menu items, it wraps around.
My patch simply makes the line minimally shorter:
Select from Menu [012], or press [ENTER] 2 Singlestepping (F8) is OFF
If you hit space, the old version changes to:
Select from Menu [012], or press [ENTER - Singlestepping (F8) is: OFF OFF
This has two errors: The ] is removed and OFF is visible twice.
A good menu line should show the menu choices, hint people about
the F5 and F8 key (if you ask me, F8 does not need to be a toggle,
it can also be "hit it at least once to enable single stepping")
and about the time left until the default choice is selected. It
could even show which selection is the default one.
It would be good to have better suggestions than my patch above, to
get a really nice menu line :-).
As far as I remember, the unstable kernel shows an even longer
menu thing which is 3 lines long (which is not nice if you want
to read the messages of your BIOS POST) and uses gotoxy (which
is not so nice if you use a serial console). I think the 3 line
style has the F5/F8 hint and status at the bottom, choice list
2 lines above, timeout line in the line between both lines.
What I would want is a ONE line menu thing.
Example, the [2] would be the timeout-for-default countdown:
Select from Menu [012], ENTER for default, F8 for singlestepping [2]
If you hit F8 at least one, this could change to:
Select from Menu [012], ENTER for default. Singlestepping is on! [2]
Instead of "ENTER for default", one could write "ENTER for [1]"
where 1 is the default in this example.
Whatever. Suggestions please :-).
Thanks! Eric
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Freedos-kernel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freedos-kernel
