I'd have to check the sources I have here for several dos versions, but having share only check be performed upon open/close of files makes perfect sense to me, In fact, couldn't there be a flag raised upon share install, then unset when share is removed, thereby making the check as simple as looking at a bit somewhere? I've not looked at the source for freedos lately, so forgive me if this is what's already done. Share needs to be checked during delete operations as well, (assuming freedos doesn't open the file to remove it) Otherwise, your suggestion sounds like a good one to me. Of course, I'm not the worlds best asm/c person, so perhaps my input should only be taken as a general agreement, and not an actual vote of any kind.
On Aug 30, 2008, at 12:35 PM, Eric Auer wrote: > > Hi, > > dunno how other DOSes do this, but I suggest that > FreeDOS only calls int 2f.1000 SHARE install check > when files are opened/closed, not on each access > (merge_file_changes, DosRWSft, DosLockUnlock). > > Background: FreeDOS at the moment calls the SHARE > install check 100s of times even for really trivial > activities. That cannot be normal? Is that needed? > > Note that FreeDOS stops calling the install check > as soon as you do install SHARE - which means you > cannot ever uninstall SHARE because FreeDOS will > fail to notice that you removed SHARE... > > Comments please :-) > > Eric > > PS: I already have a patch for this available. > Just want to hear your opinion about possible > side effects first... > > > > ------------------------------------------------------------------------- > This SF.Net email is sponsored by the Moblin Your Move Developer's > challenge > Build the coolest Linux based applications with Moblin SDK & win > great prizes > Grand prize is a trip for two to an Open Source event anywhere in > the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > _______________________________________________ > Freedos-kernel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/freedos-kernel > > ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Freedos-kernel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/freedos-kernel
