On Fri, Jun 29, 2018 at 8:48 PM, Kees Cook <keesc...@chromium.org> wrote:
> In the quest to remove all stack VLA usage from the kernel[1], this
> switches to using a kasprintf()ed buffer. Return paths are updated
> to free the allocation.
>
> [1]
> https://lkml.kernel.org/r/CA+55aFzCG-zNmZwX4A2FQpadafLfEzK6CC=qpxydaacu1rq...@mail.gmail.com
>
> Signed-off-by: Kees Cook <keesc...@chromium.org>
> ---
> drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 7 +++++--
> drivers/gpu/drm/msm/adreno/adreno_gpu.c | 28 +++++++++++++++++--------
> 2 files changed, 24 insertions(+), 11 deletions(-)
This seems fine, though using a fixed-length string is probably just
as well here,
given that the 'fwname' variable is always set to the constant string
"a530_zap.mdt"
at the moment, which is not very long.
Reviewed-by: Arnd Bergmann <a...@arndb.de>
Arnd
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
