Quoting Dmitry Baryshkov (2022-07-07 20:46:43) > On 08/07/2022 04:28, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2022-07-07 14:31:56) > >> The p1 region was probably added by mistake, none of the DTS files > >> provides one (and the driver source code also doesn't use one). Drop it > >> now. > > > > Yes, looks like the driver doesn't use it. > > > >> > >> Fixes: 687825c402f1 ("dt-bindings: msm/dp: Change reg definition") > >> Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > >> --- > >> Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >> b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >> index 94bc6e1b6451..d6bbe58ef9e8 100644 > >> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > >> @@ -29,7 +29,6 @@ properties: > >> - description: aux register block > >> - description: link register block > >> - description: p0 register block > >> - - description: p1 register block > > > > The p1 registers exist on sc7180. They start where the example starts, > > at 0xae91400. > > Do they exist on e.g. sc7280? In other words, should we add the region > to the DTS? For now I'm going to mark it as optional. >
Yes I see the same address for P1 on sc7280. Maybe it's a typo? Abhinav, can you confirm?