Hi Thomas, I love your patch! Yet something to improve:
[auto build test ERROR on 7d3e7f64a42d66ba8da6e7b66a8d85457ef84570] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-client-Test-for-connectors-before-sending-hotplug-event/20230124-214220 base: 7d3e7f64a42d66ba8da6e7b66a8d85457ef84570 patch link: https://lore.kernel.org/r/20230124134010.30263-7-tzimmermann%40suse.de patch subject: [Intel-gfx] [PATCH v2 06/10] drm/fb-helper: Initialize fb-helper's preferred BPP in prepare function config: x86_64-randconfig-a014-20230123 (https://download.01.org/0day-ci/archive/20230125/202301252016.vm7ksfra-...@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/70e38534e74e4d12bb02b3b352bba2aed417f541 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Thomas-Zimmermann/drm-client-Test-for-connectors-before-sending-hotplug-event/20230124-214220 git checkout 70e38534e74e4d12bb02b3b352bba2aed417f541 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/gma500/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): >> drivers/gpu/drm/gma500/framebuffer.c:412:44: error: too many arguments to >> function call, expected 3, have 4 drm_fb_helper_prepare(dev, fb_helper, 32, &psb_fb_helper_funcs); ~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~ include/drm/drm_fb_helper.h:295:20: note: 'drm_fb_helper_prepare' declared here static inline void drm_fb_helper_prepare(struct drm_device *dev, ^ >> drivers/gpu/drm/gma500/framebuffer.c:421:46: error: too few arguments to >> function call, expected 2, have 1 ret = drm_fb_helper_initial_config(fb_helper); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ include/drm/drm_fb_helper.h:459:19: note: 'drm_fb_helper_initial_config' declared here static inline int drm_fb_helper_initial_config(struct drm_fb_helper *fb_helper, ^ 2 errors generated. vim +412 drivers/gpu/drm/gma500/framebuffer.c 397 398 int psb_fbdev_init(struct drm_device *dev) 399 { 400 struct drm_fb_helper *fb_helper; 401 struct drm_psb_private *dev_priv = to_drm_psb_private(dev); 402 int ret; 403 404 fb_helper = kzalloc(sizeof(*fb_helper), GFP_KERNEL); 405 if (!fb_helper) { 406 dev_err(dev->dev, "no memory\n"); 407 return -ENOMEM; 408 } 409 410 dev_priv->fb_helper = fb_helper; 411 > 412 drm_fb_helper_prepare(dev, fb_helper, 32, &psb_fb_helper_funcs); 413 414 ret = drm_fb_helper_init(dev, fb_helper); 415 if (ret) 416 goto free; 417 418 /* disable all the possible outputs/crtcs before entering KMS mode */ 419 drm_helper_disable_unused_functions(dev); 420 > 421 ret = drm_fb_helper_initial_config(fb_helper); 422 if (ret) 423 goto fini; 424 425 return 0; 426 427 fini: 428 drm_fb_helper_fini(fb_helper); 429 free: 430 kfree(fb_helper); 431 return ret; 432 } 433 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
